fix: update CSS custom properties on preview panel resize#22
Merged
Conversation
The --lynx-vh and --lynx-vw custom properties are now dynamically updated when the preview panel is resized. Previously, injectStyleRules only took effect at template load time, so dimensions weren't recalculated on resize. Now we maintain a <style> element in the shadow DOM and update it directly on each resize, ensuring vh/vw viewport units inside <lynx-view> respond to container dimension changes.
✅ Deploy Preview for lynx-go-web ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Replace shadow DOM <style> element approach with setting CSS custom properties directly on the host element's inline style, which is inherited by shadow DOM descendants immediately and reliably.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The --lynx-vh and --lynx-vw custom properties inside now dynamically update when the preview panel is resized. Previously, injectStyleRules only took effect at template load time, preventing viewport unit calculations from responding to dimension changes.
We now maintain a <style> element in the shadow DOM and update it directly on each resize event, ensuring vh/vw viewport units work correctly as the container is resized.