Skip to content

chore: reduce future diff noise (formatting/hooks) + fix TS Node typings and a11y lint#30

Merged
Dugyu merged 1 commit intolynx-community:mainfrom
Dugyu:chore/clean-up
Apr 15, 2026
Merged

chore: reduce future diff noise (formatting/hooks) + fix TS Node typings and a11y lint#30
Dugyu merged 1 commit intolynx-community:mainfrom
Dugyu:chore/clean-up

Conversation

@Dugyu
Copy link
Copy Markdown
Collaborator

@Dugyu Dugyu commented Apr 15, 2026

Context
This PR is a maintenance pass to make future feature work less noisy and easier to review. It standardizes formatting and pre-commit behavior, and fixes a handful of TypeScript and accessibility lint issues that otherwise keep resurfacing during unrelated changes.

What Changed

  • Tooling / formatting
    • Add Prettier config + lint-staged + Husky pre-commit hook.
    • Add editor settings to format on save (modifications only) and keep imports organized.
    • Disable the “no inline styles” hint rule (the codebase intentionally uses inline styles in many places).
  • TypeScript / module resolution
    • Add @types/node where Node built-ins are imported (SSG + example configs).
    • Stop excluding SSG files from the root TS project so they are typechecked normally.
    • Define ImportMetaEnv to type import.meta.env.SSG_MD, EXAMPLES, SSG_PREVIEWS.
    • Fix Shiki dynamic import typing (import('shiki') is a Promise; .then is not a type member).
  • Accessibility lint fixes
    • Use valid, literal aria-orientation values on the split pane separator.
    • Add accessible names (aria-label) for <select> and related <input> controls in the example app.

Why This Helps

  • Prevents formatting churn in future PRs (review diffs stay focused on behavior changes).
  • Avoids repeated TS noise around Node built-ins and import.meta.env typing.
  • Keeps a11y lint from blocking unrelated changes.

Verification

  • pnpm typecheck (repo root)
  • pnpm exec tsc --noEmit (under example/)

- Add Prettier + lint-staged + Husky pre-commit to keep formatting consistent and reduce diff noise
- Add Node.js type deps to avoid `fs/path` module resolution issues in SSG / config files
- Tighten TS env typings (`ImportMetaEnv`) for `import.meta.env.*` usage across packages
- Fix a11y lint issues (ARIA values + accessible names for select/inputs)
- Regenerate lockfiles after dependency updates
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 15, 2026

Deploy Preview for lynx-go-web ready!

Name Link
🔨 Latest commit 969a4f0
🔍 Latest deploy log https://app.netlify.com/projects/lynx-go-web/deploys/69df5d16c13de60008c80dd8
😎 Deploy Preview https://deploy-preview-30--lynx-go-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Dugyu Dugyu merged commit 5e04275 into lynx-community:main Apr 15, 2026
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant