WIP: feat: add testbench plugin#22
Closed
ZhaoSongGOO wants to merge 1 commit intolynx-family:mainfrom
ZhaoSongGOO:p/zhaosonggo/testbench_enable_plugin
Closed
WIP: feat: add testbench plugin#22ZhaoSongGOO wants to merge 1 commit intolynx-family:mainfrom ZhaoSongGOO:p/zhaosonggo/testbench_enable_plugin
ZhaoSongGOO wants to merge 1 commit intolynx-family:mainfrom
ZhaoSongGOO:p/zhaosonggo/testbench_enable_plugin
Conversation
Change-Id: Ic15a5a44573199ca48a8070b1db70f351b88070a
talisk
changed the title
talisk
requested changes
Mar 17, 2025
| await Promise.all(allStreams); | ||
| this.clientAction?.setTestbenchLoading(clientId, false); | ||
| } else { | ||
| // 未返回有效数据 |
Collaborator
There was a problem hiding this comment.
Plz write comments in English
| @@ -0,0 +1,48 @@ | |||
| import create from '../utils/flooks'; | |||
| const deviceModel = currentClient?.info?.deviceModel; | ||
| const osType = currentClient?.info?.osType; | ||
| const PIC_URL_PREFIX = 'data:image/jpeg;base64,'; | ||
| const qr_url = `sslocal://arkview?url=$`; |
Collaborator
There was a problem hiding this comment.
We shouldn't use this schema. And there's also arkview.
talisk
reviewed
Mar 17, 2025
| <Popover | ||
| content={ | ||
| <div className="testbentch-qrcode-pop"> | ||
| <div>Use the LynxExample App to scan the QR code</div> |
Collaborator
There was a problem hiding this comment.
There's no LynxExample App
Collaborator
There was a problem hiding this comment.
And we are not sure what form Lynx DevTool connects to the host application through web socket in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: Ic15a5a44573199ca48a8070b1db70f351b88070a