-
Notifications
You must be signed in to change notification settings - Fork 111
feat: share runtime-components exports between the main and lazy bundles
#1895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ain and lazy bundles
🦋 Changeset detectedLatest commit: 5023aa5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📝 WalkthroughWalkthroughThis PR adds lazy bundle support for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes The changes follow a consistent, homogeneous pattern across files—adding a new lazy export path through the existing symbol-based mapping system. While understanding the lazy loading architecture is helpful, individual changes are straightforward and repetitive in nature. Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@lynx-js/react/runtime-components exports between the m…runtime-components exports between the main and lazy bundles
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
React Example#5954 Bundle Size — 237.5KiB (0%).5023aa5(current) vs 353312e main#5953(baseline) Bundle metrics
|
| Current #5954 |
Baseline #5953 |
|
|---|---|---|
0B |
0B |
|
0B |
0B |
|
0% |
0% |
|
0 |
0 |
|
4 |
4 |
|
165 |
165 |
|
67 |
67 |
|
46.77% |
46.77% |
|
2 |
2 |
|
0 |
0 |
Bundle size by type no changes
| Current #5954 |
Baseline #5953 |
|
|---|---|---|
145.76KiB |
145.76KiB |
|
91.74KiB |
91.74KiB |
Bundle analysis report Branch upupming:feat/disable-page-in-la... Project dashboard
Generated by RelativeCI Documentation Report issue
Web Explorer#5950 Bundle Size — 364.68KiB (0%).5023aa5(current) vs 353312e main#5949(baseline) Bundle metrics
Bundle size by type
|
| Current #5950 |
Baseline #5949 |
|
|---|---|---|
238.77KiB |
238.77KiB |
|
93.8KiB |
93.8KiB |
|
32.11KiB |
32.11KiB |
Bundle analysis report Branch upupming:feat/disable-page-in-la... Project dashboard
Generated by RelativeCI Documentation Report issue
CodSpeed Performance ReportMerging #1895 will improve performances by 6.32%Comparing Summary
Benchmarks breakdown
Footnotes
|
The
Pagecomponent has a singletonpageMountedvariable. It should be shared between the main and lazy bundles to make it work properly in lazy bundle.Summary by CodeRabbit
Checklist