[Patch] [BugFix][Android] Fix clay emoji rendered failure and layout errors on Android.#7368
Open
lynxassistant[bot] wants to merge 3 commits into
Open
[Patch] [BugFix][Android] Fix clay emoji rendered failure and layout errors on Android.#7368lynxassistant[bot] wants to merge 3 commits into
lynxassistant[bot] wants to merge 3 commits into
Conversation
…ement to renderer - What changed Added an onMeasure override in UIBody.UIBodyView. When shouldDrawWithDisplayList() returns true, measurement is delegating to the renderer's measure method instead of using the default View onMeasure behavior. - Why it was needed In fragment layer / display list render mode, letting the default View onMeasure run could override the measured dimensions set by the renderer and lead to incorrect layout or extra measure passes. - How it was verified / impacts This change keeps onMeasure consistent with the existing onLayout and onDraw renderer delegation paths and avoids redundant measurement work in display-list mode. [internal] TEST: existing Android unit tests and LynxExample verification [end-internal]
…ement to renderer - What changed Added an onMeasure override in UIBody.UIBodyView. When shouldDrawWithDisplayList() returns true, measurement is delegating to the renderer's measure method instead of using the default View onMeasure behavior. - Why it was needed In fragment layer / display list render mode, letting the default View onMeasure run could override the measured dimensions set by the renderer and lead to incorrect layout or extra measure passes. - How it was verified / impacts This change keeps onMeasure consistent with the existing onLayout and onDraw renderer delegation paths and avoids redundant measurement work in display-list mode. [internal] TEST: existing Android unit tests and LynxExample verification [end-internal]
…n Android. - Rendering failure is caused by R8 obfuscating on Andoird and this patch replace those relection calls through lynx_clay module. - Layout error is because clay tttext did not handle `kMiddle` alignment cases. AutoLand: release/3.8, release/3.9, release/4.0 issue: m-7336713635
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.