[Feature][Clay][Text] Support selection handle style attrs#7483
Open
lynxassistant[bot] wants to merge 1 commit into
Open
[Feature][Clay][Text] Support selection handle style attrs#7483lynxassistant[bot] wants to merge 1 commit into
lynxassistant[bot] wants to merge 1 commit into
Conversation
jianliang00
force-pushed
the
shadow/p/ci_lynx/x-hand-size
branch
from
ef0bfa7 to
eabcf6f
Compare
- Add Clay text selection handling for selection handle size and color attributes. - Apply cached handle styles when selection handles are shown and rebuild visible handles from TextView when the handle size changes. - Return configured handle radius from setTextSelection and use the last selected line for the end handle in multiline selections. - Fix the built-in selection popup item line-height ratio so copy and select-all labels align with their menu bounds. - Add unit coverage for handle radius updates, TextView-driven handle geometry rebuilds, handle color fallback, and setTextSelection handle metadata. TEST: tools/env.sh git diff --check TEST: tools/env.sh ninja -C out/clay_ut clay_unittests (fails at final link because zlib is missing from the command) TEST: Manual link of out/clay_ut/clay_unittests with -lz TEST: tools/env.sh ./out/clay_ut/clay_unittests --gtest_filter='TextSelectionTest.*:SelectionHandleViewTest.*'
jianliang00
force-pushed
the
shadow/p/ci_lynx/x-hand-size
branch
from
eabcf6f to
439185a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.