Skip to content

[Patch] [BugFix] Record Android text content in frame recorder #7515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rAY-ooo wants to merge 1 commit into
base: release/4.0
Choose a base branch
from
Open

[Patch] [BugFix] Record Android text content in frame recorder #7515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions core/public/painting_ctx_platform_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,6 @@ struct InitialLynxUITreeNodeForReplay {
int id = 0;
std::string tag;
fml::RefPtr<PropBundle> painting_data;
bool flatten = false;
uint32_t node_index = 0;

bool has_parent = false;
int parent = 0;
Expand Down
2 changes: 0 additions & 2 deletions core/renderer/dom/element_manager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,6 @@ void CollectElementContainerForReplay(
node.id = element->impl_id();
node.tag = element->GetPlatformNodeTag().str();
node.painting_data = element->GetPropBundleForRecording();
node.flatten = element->TendToFlatten();
node.node_index = element->NodeIndex();
const auto layout = container->CalculateCurrentPlatformLayout();
if (ui_parent != nullptr) {
node.has_parent = true;
Expand Down
17 changes: 2 additions & 15 deletions core/renderer/ui_wrapper/painting/android/painting_context_android.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,8 +735,6 @@ void PaintingContextAndroid::RecordInitialLynxUITreeForReplay(
std::vector<jint> signs(size);
std::vector<jint> parent_signs(size);
std::vector<jint> child_indexes(size);
std::vector<jint> node_indexes(size);
std::vector<jboolean> flattens(size);
std::vector<jboolean> has_bounds(size);
std::vector<jboolean> has_sticky(size);
std::vector<jfloat> layouts(layout_size);
Expand Down Expand Up @@ -766,8 +764,6 @@ void PaintingContextAndroid::RecordInitialLynxUITreeForReplay(
signs[index] = node.id;
parent_signs[index] = node.has_parent ? node.parent : -1;
child_indexes[index] = node.has_parent ? node.index : -1;
node_indexes[index] = static_cast<jint>(node.node_index);
flattens[index] = static_cast<jboolean>(node.flatten);
has_bounds[index] = static_cast<jboolean>(node.has_bounds);
has_sticky[index] = static_cast<jboolean>(node.has_sticky);

Expand Down Expand Up @@ -804,11 +800,7 @@ void PaintingContextAndroid::RecordInitialLynxUITreeForReplay(
env, env->NewIntArray(java_size));
base::android::ScopedLocalJavaRef<jintArray> child_indexes_ref(
env, env->NewIntArray(java_size));
base::android::ScopedLocalJavaRef<jintArray> node_indexes_ref(
env, env->NewIntArray(java_size));

base::android::ScopedLocalJavaRef<jbooleanArray> flattens_ref(
env, env->NewBooleanArray(java_size));
base::android::ScopedLocalJavaRef<jbooleanArray> has_bounds_ref(
env, env->NewBooleanArray(java_size));
base::android::ScopedLocalJavaRef<jbooleanArray> has_sticky_ref(
Expand All @@ -822,10 +814,6 @@ void PaintingContextAndroid::RecordInitialLynxUITreeForReplay(
parent_signs.data());
env->SetIntArrayRegion(child_indexes_ref.Get(), 0, java_size,
child_indexes.data());
env->SetIntArrayRegion(node_indexes_ref.Get(), 0, java_size,
node_indexes.data());
env->SetBooleanArrayRegion(flattens_ref.Get(), 0, java_size,
flattens.data());
env->SetBooleanArrayRegion(has_bounds_ref.Get(), 0, java_size,
has_bounds.data());
env->SetBooleanArrayRegion(has_sticky_ref.Get(), 0, java_size,
Expand All @@ -836,9 +824,8 @@ void PaintingContextAndroid::RecordInitialLynxUITreeForReplay(

Java_PaintingContext_recordInitialTreeForReplay(
env, local_ref.Get(), signs_ref.Get(), tag_names.Get(), bundles.Get(),
styles.Get(), flattens_ref.Get(), node_indexes_ref.Get(),
parent_signs_ref.Get(), child_indexes_ref.Get(), layouts_ref.Get(),
has_bounds_ref.Get(), has_sticky_ref.Get());
styles.Get(), parent_signs_ref.Get(), child_indexes_ref.Get(),
layouts_ref.Get(), has_bounds_ref.Get(), has_sticky_ref.Get());
});
}

Expand Down
Loading
Loading