[Feature] Pass display_none to platform and skip draw in fragment layer#7524
Open
zhongyr wants to merge 2 commits into
Open
[Feature] Pass display_none to platform and skip draw in fragment layer#7524zhongyr wants to merge 2 commits into
zhongyr wants to merge 2 commits into
Conversation
- What changed Add a display_none flag to LayoutContext::Delegate::OnLayoutUpdate and Element::UpdateLayout. LayoutContext::UpdateLayoutInfo and FiberElement::UpdateLayoutInfo now read the flag from the Starlight layout result and pass it down. Element stores the flag and exposes it via display_none(). - Why it was needed Downstream code needs to know whether a node is treated as display:none by the layout engine without recomputing it from CSS. - How it was verified Ran layout_context_tests_exec, tasm_unittests_exec, layout_tests_exec, and fragment_test_exec. All passed. TEST: layout_context_tests_exec, tasm_unittests_exec, layout_tests_exec, fragment_test_exec AutoLand: release/4.0 AutoSubmit: true
…ay list - What changed Add a display_none flag to PaintingCtxPlatformImpl::UpdateLayout and the PaintingContext wrapper. All platform implementations (Android, iOS, Harmony, empty, mocks) now accept the flag. ElementContainer::UpdateLayout passes element()->display_none() through painting_context()->UpdateLayout. In FragmentLayerRender mode, Fragment::Draw() no longer returns early when element()->display_none() is true. Instead it emits a display list containing only the node's Begin/End so the platform layer receives an update and clears stale content, sublayers, and event-target state instead of keeping the previous frame. ReconstructEventTargetTreeForExposure() still runs as before. - Why it was needed Returning early left the previous frame's display list / sublayer / event target tree active on the platform side when a node switched to display:none. - How it was verified Ran dom_unittest_exec. Fragment tests and the new DisplayNoneEmitsEmptyDisplayListAndReconstructsExposure test passed. TEST: dom_unittest_exec AutoSubmit: true AutoLand: true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.