[BugFix] Fix Clay default font family and measured width on iOS - #8835
[BugFix] Fix Clay default font family and measured width on iOS#8835Neilcc wants to merge 1 commit into
Conversation
Keep Clay text measured width and font-size as float through the measurement path. Recover TTText fractional line widths from paragraph line metrics when safe. Keep existing default font family behavior unchanged. SkipChecks: macro AutoLand: release/3.9, release/3.8
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1db604b386
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 0.0); | ||
| measured_height_ = | ||
| std::ceil(cache_paragraph_->GetHeight() - line_spacing); | ||
| measured_height_ = cache_paragraph_->GetHeight() - line_spacing; |
There was a problem hiding this comment.
When a regular <text> node is measured with an indefinite or at-most height and the paragraph backend returns a fractional height, removing ceil here changes the externally returned height because TextShadowNode::Measure assigns context.measured_height_ directly to result.height. This differs from the updated internal/inner text paths, which still ceil at the result boundary, and contradicts the new height policy in text_measure_spec.md; keep the intermediate value fractional but apply ceil when producing the non-definite MeasureResult.
Useful? React with 👍 / 👎.
1 participant
No description provided.