Skip to content

Typo fixes - #224

Open
elanora96 wants to merge 2 commits into
lynxthecat:next-versionfrom
elanora96:next-version
Open

Typo fixes#224
elanora96 wants to merge 2 commits into
lynxthecat:next-versionfrom
elanora96:next-version

Conversation

@elanora96

Copy link
Copy Markdown

Hey I'm back from #212, this time messing with next-version, copy and pasting the body from that PR

I noticed a typo while using adblock-lean, and found a few more with typos-cli. Sort of a nitpicky PR but they are fixed in the two commits attached.

I'm happy to squash, split, or discard as needed. And thank you for adblock-lean, it's a really wonderful tool.

BTW, are there any plans for a luci interface? I may start my own soon unless I'm missing an official implementation

@rickparrish

rickparrish commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

I'm not sure if it'll help because (1) I didn't really know what I was doing so there was a lot of copying bits and pieces from other luci apps so it's probably not well architected, and (2) it's several releases behind, but I put together a luci app that worked well for awhile.

If you're interested in taking a look to see if it'll have any value as a base or reference, the repo is here: https://github.com/rickparrish/luci-app-adblock-lean

@friendly-bits

friendly-bits commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Hey, thank you again. I haven't pushed updates to the next-version branch for a while because the code in it is undergoing some heavy modifications. I discovered some fundamental flaws in the revision which is currently available in this repo and been working through them. As part of that, I extracted the job scheduler implementation from adblock-lean and made a standalone library out of it which addresses the needs of the next version, and now working on re-integrating that library into adblock-lean code. It'll take some more time before the code reaches the point where it's ready to be merged into the next-version branch.

Once that lands, I'll see what to do about this PR.

As to luci app personally I am not planning to do any such implementation and neither does @lynxthecat , as far as I'm aware - so by all means, go ahead with it. Just expect the updated next-version code to change some options in the future. I will be happy to work with you on providing the backend functionality needed.

@elanora96

elanora96 commented Aug 5, 2026

Copy link
Copy Markdown
Author

Cool, I'll just leave this open. I also don't mind if you just want to fix some of these typos yourself rather than pulling this fwiw.

As far as a luci app I'll spend this week studying luci apps, including @rickparrish's. Fair chance I just end up forking yours Rick and seeing how far I can get with 0.8 and next-version support this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants