fix: apply env QR presets on initial page load#287
Open
aleex1848 wants to merge 1 commit into
Open
Conversation
Presets from VITE_QR_CODE_PRESETS were not applied on first visit because the selectedPreset watcher did not run immediately. The frame preset watcher also overwrote frame styles from the QR preset when run with immediate: true.
Contributor
|
@aleex1848 is attempting to deploy a commit to the lyqht's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VITE_QR_CODE_PRESETS(and embeddedframeon presets) on first page load, not only after manual config import or preset change.selectedPresetwatcher with{ immediate: true }viaapplySelectedPresetToState().immediate: true).Problem
When self-hosting with env-defined presets, logo/colors/frame were wrong on first visit but correct after loading a JSON config or switching presets.
Test plan
VITE_QR_CODE_PRESETS(logo + colors).frame, frame styles apply on first load.