Lattice Range + Displacement Cleanup #649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evaleev
reviewed
Jan 15, 2026
Contributor
Author
|
Found a small problem. Don't merge this until the next commit... EDIT: Done |
evaleev
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (which would benefit from squashing the commits) has two primary features. First, it adds the
LatticeRangeclass and integrates it to the lattice summation within 1D convolutions. Secondly, it refactors the logic surrounding displacements. @evaleev described the old code as PTSD-inducing when I was going over the rewrite with him this morning. The primary changes are adding comments, renaming functions for clarity, the complete rewrite ofreset_along_dim, and the use of theExtraDomainPolicyenum in theBoxSurfaceDomainValidatorwhich is more descriptive and eliminates the redundancies of the previous two-arrays-of-bool system.