Skip to content

Commit 504e3e5

Browse files
Add a GCS project flag (#20)
* Add GCP project flag * Use PROJECT_ID variable * Rename GCS
1 parent 0216d60 commit 504e3e5

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

cloudbuild.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ steps:
3535
- |-
3636
sed -i -e 's/{{COMMIT_SHA}}/'${COMMIT_SHA}'/' \
3737
-e 's/{{PROJECT_ID}}/'${PROJECT_ID}'/' \
38+
-e 's/{{VIEW_PROJECT}}/'$_VIEW_PROJECT'/' \
39+
-e 's/{{GCS_PROJECT}}/'$_GCS_PROJECT'/' \
3840
-e 's/{{MLAB_BUCKET}}/'$_MLAB_BUCKET'/' \
3941
-e 's/{{BUCKETS}}/'$_BUCKETS'/' \
4042
k8s/autoloader.yaml

cmd/autoloader/main.go

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,19 @@ import (
1717

1818
var (
1919
listenAddr string
20-
project string
20+
bqProject string
2121
viewProject string
22+
gcsProject string
2223
mlabBucket string
2324
bucketNames flagx.StringArray
2425
mainCtx, mainCancel = context.WithCancel(context.Background())
2526
)
2627

2728
func init() {
2829
flag.StringVar(&listenAddr, "listenaddr", ":8080", "Address to listen on")
29-
flag.StringVar(&project, "project", "mlab-sandbox", "BigQuery project environment variable")
30+
flag.StringVar(&bqProject, "bq-project", "mlab-sandbox", "BigQuery project environment variable")
3031
flag.StringVar(&viewProject, "view-project", "mlab-sandbox", "BigQuery project for views")
32+
flag.StringVar(&gcsProject, "gcs-project", "mlab-sandbox", "GCS project")
3133
flag.StringVar(&mlabBucket, "mlab-bucket", "", "Archive bucket name containing data from M-Lab's platform")
3234
flag.Var(&bucketNames, "buckets", "Archive bucket names in Google Cloud Storage")
3335
}
@@ -43,14 +45,14 @@ func main() {
4345
storage, err := storage.NewClient(mainCtx)
4446
rtx.Must(err, "Failed to create storage client")
4547
defer storage.Close()
46-
gcs := gcs.NewClient(storage, bucketNames, mlabBucket, project)
48+
gcs := gcs.NewClient(storage, bucketNames, mlabBucket, gcsProject)
4749

48-
bqMain, err := bigquery.NewClient(mainCtx, project)
50+
bqMain, err := bigquery.NewClient(mainCtx, bqProject)
4951
rtx.Must(err, "Failed to create BigQuery client")
5052
defer bqMain.Close()
5153

5254
bqView := bqMain
53-
if project != viewProject {
55+
if bqProject != viewProject {
5456
bqView, err = bigquery.NewClient(mainCtx, viewProject)
5557
rtx.Must(err, "Failed to create BigQuery view client")
5658
defer bqView.Close()

k8s/autoloader.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,9 @@ spec:
3131
image: gcr.io/{{PROJECT_ID}}/autoloader:{{COMMIT_SHA}}
3232
args:
3333
- -listenaddr=:8080
34-
- -project={{PROJECT_ID}}
34+
- -bq-project={{PROJECT_ID}}
35+
- -view-project={{VIEW_PROJECT}}
36+
- -gcs-project={{GCS_PROJECT}}
3537
- -mlab-bucket={{MLAB_BUCKET}}
3638
- -buckets={{BUCKETS}}
3739
- -prometheusx.listen-address=:9990

0 commit comments

Comments
 (0)