Skip to content

fix: correct argparse long options and logger TypeError#143

Open
Famous077 wants to merge 1 commit intom-lab:mainfrom
Famous077:fix/argparse-long-options-and-logger-typeerror
Open

fix: correct argparse long options and logger TypeError#143
Famous077 wants to merge 1 commit intom-lab:mainfrom
Famous077:fix/argparse-long-options-and-logger-typeerror

Conversation

@Famous077
Copy link

@Famous077 Famous077 commented Mar 3, 2026

Fixes #139

Changes:

  • Fixed -path and -url to --path and --url in scripts/upload.py so argparse correctly treats them as long options
  • Replaced string concatenation "export failed: " + ex with logger.error("export failed: %s", ex) in murakami/exporter.py to prevent TypeError when ex is not a string

This change is Reviewable

@Famous077
Copy link
Author

This PR fixes issue #139 corrected -path/-url to --path/--url in upload.py and replaced unsafe string concatenation in logger.error() with %s formatting in exporter.py. Both files verified with py_compile.

Happy to make any updates based on your feedback. Thank you

@Famous077
Copy link
Author

The test stage passes on Python 3.6 and 3.7.
The deploy stage failure is unrelated to this PR ,
it requires PyPI credentials that are not available in fork PR builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix CLI long options and logger TypeError

1 participant