feat: implement DASH output parser with structured JSON and unit tests#145
Open
Famous077 wants to merge 1 commit intom-lab:mainfrom
Open
feat: implement DASH output parser with structured JSON and unit tests#145Famous077 wants to merge 1 commit intom-lab:mainfrom
Famous077 wants to merge 1 commit intom-lab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Resolves the TODO in
dash.py— replaces raw last-line output with structured JSON, consistent withndt7andndt5runners.Issue number : #138
Changes:
dash.py: Parsesdash-client -format=jsonoutput per segment, computes avg download speed, latency, bytes received, and handles errors gracefully with null fieldstests/test_dash.py: 4 new tests covering success, failure, missing binary, and empty outputTesting
4 passed in 0.11s
This change is