Merged
Conversation
In m-lab/mlab-speedtest#81, I chased a pretty annoying bug where there was a reference error. Also, run `npm install` to update the `package-lock.json`. The minified files made it rather complex to understand what was the actual error, and this got me thinking: _why_ do we minify files that are otherwise already tiny by _any_ standard ahead of running a speedtest that is going to transfer _lots_ of data? So, with this pull request I am proposing that we drop minification and we just use the actual small files, which, in turn, will make debugging and fast iteration more plausible. I suspect that the culprit is when we upgraded minify (though I did not investigate the matter deeply). What I tested is that, running `m-lab/mlab-speedtest` locally, the minified files using `0.1.3` fail with `cannot access 'g' before initialization` while replacing the minified files with the actual file works as intended. At this point, I decided chasing the bug was unimportant and the right thing to do was instead to drop the unnecessary minification complexity. See m-lab/mlab-speedtest#81 (comment)
robertodauria
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In m-lab/mlab-speedtest#81, I chased a pretty annoying bug where there was a reference error.
The minified files made it rather complex to understand what was the actual error, and this got me thinking: why do we minify files that are otherwise already tiny by any standard ahead of running a speedtest that is going to transfer lots of data?
So, with this pull request I am proposing that we drop minification and we just use the actual small files, which, in turn, will make debugging and fast iteration more plausible.
I suspect that the culprit is when we upgraded minify (though I did not investigate the matter deeply). What I tested is that, running
m-lab/mlab-speedtestlocally, the minified files using0.1.3fail withcannot access 'g' before initializationwhile replacing the minified files with the actual file works as intended. At this point, I decided chasing the bug was unimportant and the right thing to do was instead to drop the unnecessary minification complexity.See m-lab/mlab-speedtest#81 (comment)
Also, run
npm installto update thepackage-lock.json.This change is