Conversation
…ract test The release pipeline runs `tsc -b` in desktop/frontend strict mode, which the regular CI does not — so this slipped through PR #72 and PR #73 and broke v7.0.0 tag-build matrix on linux-arm64 (and fail-fast cancelled the rest). `fixture.unknown_status_examples` is `readonly string[]` by design — the test deliberately feeds invalid strings to `projectReadiness` to verify that `isProjectReadiness` filtering rejects them. TS strict refuses `string -> "ready" | "needs_init" | "needs_onboard" | "missing" | undefined` without a cast. Casting at the call site preserves the test's intent (exercise the rejection path) while satisfying the type checker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixture.unknown_status_examplesentries toProjectReadinessat the test call sitedesktop/frontendtsc -bstrict mode in the release workflow'sBuild CLImatrixBuild CLI linux-arm64failing first → fail-fast cancelled the rest of the matrix on the original v7.0.0 tag runTest plan
npm --prefix desktop/frontend run buildgreen locallygo test ./...green via lefthook pre-push🤖 Generated with Claude Code