Conversation
The download URL regex `browser_download_url.*${os_arch}.tar.gz` matched
BOTH `haft-${os_arch}.tar.gz` and `haft-desktop-${os_arch}.tar.gz`. The
desktop variant sorts first in the GitHub API response (alphabetical),
so `head -1` picked the Tauri shell archive instead of the CLI archive.
That archive ships `haft-desktop` (Linux) or `Haft.app/` (macOS), neither
of which contains the `haft` CLI binary that install.sh expects under
`./haft` or `./bin/haft` — so users hit "Binary not found in archive".
Reported externally during v7.0.0 install attempts on linux-amd64.
Anchor on `/haft-${os_arch}\.tar\.gz` (leading slash, escaped dots) so
`haft-desktop-*` URLs are excluded by the literal segment match. Verified
on all three currently-shipped CLI archs (linux-amd64, linux-arm64,
darwin-arm64) — each now resolves to the correct CLI tarball URL.
install.sh is fetched from raw.githubusercontent.com/m0n0x41d/haft/main/
install.sh, so this fix goes live for all `curl ... | bash` callers as
soon as it lands on main — no v7.0.x patch tag needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install.shregex matched bothhaft-${arch}.tar.gzandhaft-desktop-${arch}.tar.gzandhead -1picked the desktop one (alphabetically first). Users hit "Binary not found in archive" because the desktop tarball shipshaft-desktop/Haft.app, not the CLI `haft`.Test plan
curl ... | bashusers on merge