Skip to content

[codex] Add Empire AI NVL72 training launcher#777

Open
jder wants to merge 11 commits into
mainfrom
codex/empireai-nvl72-launcher
Open

[codex] Add Empire AI NVL72 training launcher#777
jder wants to merge 11 commits into
mainfrom
codex/empireai-nvl72-launcher

Conversation

@jder

@jder jder commented Jun 23, 2026

Copy link
Copy Markdown
Member

Add an example Empire AI Beta NVL72 Slurm launcher for half-degree OM4 training. Updates to latest physics nemo base image.

Drive by: default W&B runs to the ocean_emulators entity instead of the stale samudra entity.

@jder jder left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fomo-bot can you rebase on the latest main and remove the files mentioned below

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file.

Comment thread scripts/empireai_nccl_smoke.sbatch Outdated

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file.

@jder jder marked this pull request as ready for review July 9, 2026 18:26
@fomo-bot fomo-bot force-pushed the codex/empireai-nvl72-launcher branch from 448c47c to 90d56b2 Compare July 9, 2026 18:28
@fomo-bot

fomo-bot commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Rebased PR #777 onto latest origin/main and force-with-lease pushed the PR branch.

Removed the three requested files from the PR diff:

  • docs/empireai_nvl72_nccl_validation_failures.md
  • scripts/empireai_nccl_smoke.sbatch
  • scripts/empireai_validation_collective_stress.sbatch

New branch head: 90d56b2c (codex/empireai-nvl72-launcher).

Validation run:

  • git diff --check origin/main...HEAD
  • bash -n scripts/empireai_nvl72_train.sbatch scripts/slurm_apptainer_eval.sbatch scripts/slurm_apptainer_train.sbatch scripts/container/build_physicsnemo_26_05.sh scripts/container/run_cuda_tests_in_image.sh scripts/container/scrub_arm64_gpu_container_tests.sh

All passed. The review threads are now outdated on GitHub; I did not manually resolve them.

Debug info

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 448c47c8f6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/empireai_nvl72_train.sbatch

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 59c0159faf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread containers/Dockerfile.physicsnemo-26.05 Outdated
--no-install-package nvidia-cusparselt-cu13 \
--no-install-package nvidia-nccl-cu13 \
--no-install-package nvidia-nvjitlink \
--no-install-package nvidia-nvshmem \

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Exclude the cu13 nvshmem wheel on ARM builds

For aarch64 26.05 builds, the lockfile dependency is nvidia-nvshmem-cu13 from torch's ARM CUDA stack, not nvidia-nvshmem; uv sync --no-install-package skips the given package name exactly (checked uv sync --help). As written, the ARM64 container build still installs the 60MB PyPI nvidia-nvshmem-cu13 wheel into the venv instead of reusing PhysicsNeMo's image-provided CUDA libraries, which can shadow the base stack and defeats this Dockerfile's CUDA-package exclusions.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fomo-bot can you do this and review the lockfile for other missing packages please

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed commit 67e62088 to PR #777.

Changed containers/Dockerfile.physicsnemo-26.05 to exclude the exact ARM lockfile package name:

nvidia-nvshmem-cu13

I also reviewed the lockfile against the Dockerfile’s --no-install-package list. All torch CUDA nvidia-* dependencies are now covered. The only unexcluded lockfile nvidia-* package is nvidia-ml-py, which I left alone because it is not a torch CUDA runtime wheel.

Checks passed:

  • structured lockfile vs Dockerfile exclusion comparison
  • uv lock --check
  • git diff --check

The GitHub review thread is now outdated; I did not manually resolve it.

Debug info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants