Feature document #185
Merged
Feature document #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaaaaanquish
commented
Apr 3, 2021
| @@ -84,7 +81,7 @@ | |||
| # Add any paths that contain custom static files (such as style sheets) here, | |||
| # relative to this directory. They are copied after the builtin static files, | |||
| # so a file named "default.css" will overwrite the builtin "default.css". | |||
| html_static_path = ['_static'] | |||
There was a problem hiding this comment.
WARNING because this directory does not exist.
| @@ -22,6 +22,7 @@ Table of Contents | |||
| task_information | |||
| task_settings | |||
| slack_notification | |||
| using_task_cache_collision_lock | |||
There was a problem hiding this comment.
WARNING because not index using_task_cache_collision_lock.rst
| @@ -12,22 +12,23 @@ Prepare following environmental variables: | |||
| export SLACK_CHANNEL=channel-name // not "#channel-name", just "channel-name" | |||
|
|
|||
|
|
|||
| A Slack bot token can obtain from `here <https://api.slack.com/apps>`_. | |||
| A Slack bot token can obtain from `slack app document <https://api.slack.com/apps>`_. | |||
There was a problem hiding this comment.
WARNING because here is duplicated.
| @@ -3,7 +3,6 @@ | |||
|
|
|||
| import luigi | |||
|
|
|||
| import gokart | |||
| import types | ||
| from functools import partial |
vaaaaanquish
commented
Apr 3, 2021
| python: | ||
| version: 3.7 | ||
| install: | ||
| - requirements: docs/requirements.txt |
There was a problem hiding this comment.
| import gokart | ||
|
|
||
| luigi.task.Task.requires.__doc__ = gokart.task.TaskOnKart.requires.__doc__ | ||
| luigi.task.Task.output.__doc__ = gokart.task.TaskOnKart.output.__doc__ |
There was a problem hiding this comment.
WARNING because undefined label for luigi label.
hirosassa
approved these changes
Apr 3, 2021
| @@ -7,7 +7,7 @@ license = "MIT" | |||
| readme = "README.md" | |||
| homepage = "https://github.com/m3dev/gokart" | |||
| repository = "https://github.com/m3dev/gokart" | |||
| documentation = "" | |||
| documentation = "https://gokart.readthedocs.io/en/latest/" | |||
Co-authored-by: hirosassa <[email protected]>
Co-authored-by: hirosassa <[email protected]>
Co-authored-by: hirosassa <[email protected]>
Co-authored-by: hirosassa <[email protected]>
Co-authored-by: hirosassa <[email protected]>
Co-authored-by: hirosassa <[email protected]>
Co-authored-by: hirosassa <[email protected]>
Co-authored-by: hirosassa <[email protected]>
Co-authored-by: hirosassa <[email protected]>
Co-authored-by: hirosassa <[email protected]>
Co-authored-by: hirosassa <[email protected]>
Co-authored-by: hirosassa <[email protected]>
Co-authored-by: hirosassa <[email protected]>
Co-authored-by: hirosassa <[email protected]>
Co-authored-by: hirosassa <[email protected]>
Co-authored-by: hirosassa <[email protected]>
Co-authored-by: kyoh.maruo <[email protected]>
Co-authored-by: kyoh.maruo <[email protected]>
Co-authored-by: hirosassa <[email protected]>
Update Documents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update document for v1.0
TODO
Add Japanese documents