explorer-details-better-file-sizes: Harden Everything IPC waits - #84
Open
insane66613 wants to merge 1 commit into
Open
explorer-details-better-file-sizes: Harden Everything IPC waits#84insane66613 wants to merge 1 commit into
insane66613 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OVERLAPPEDobject cannot outlive the operation.Why
The current Everything3 send/receive paths can block indefinitely if an overlapped pipe operation never completes. The legacy receiver startup also waits indefinitely for a ready event, while
Everything4Wh_Threadcan return early fromCreateEvent,RegisterClassEx, orCreateWindowExwithout signaling it. Those failure paths can leave Explorer waiting forever.The 1000 ms timeout matches the existing legacy Everything IPC timeout used by the mod.
Validation
WaitForMultipleObjects(..., INFINITE)sites.git diff --check: pass.Wh_SetFunctionHookTdeprecation warnings per architecture are pre-existing and unrelated.Scope
This intentionally does not change the separate existing unbounded waits in
Wh_ModUninit(). No deliberate hung-Everything runtime fault-injection test was performed; validation is source-level regression checking plus both-architecture compilation.