Skip to content

Conversation

@jamesnrokt
Copy link
Contributor

@jamesnrokt jamesnrokt commented Dec 2, 2025

Background

  • To support partners using Rokt in conjunction with mParticle this PR creates a new package

What Has Changed

  • Adds Rokt Kit
  • Changes publishing method to match Rokt and allow for publishing both core and Rokt Kit

Screenshots/Video

iOS

Simulator.Screen.Recording.-.iPhone.17.Pro.-.2025-12-02.at.13.24.40.mov

Android

Screen_recording_20251202_132622.webm

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have tested this locally.

Additional Notes

  • First publish of the Rokt Kit will have to be done manually
  • Will migrate to using Trusted Publishing after merge
  • Versions of SDKs will be updated after the above publish

Reference Issue (For employees only. Ignore if you are an outside contributor)

  • Closes N/A

Copilot AI review requested due to automatic review settings December 2, 2025 18:30
@jamesnrokt jamesnrokt requested a review from a team as a code owner December 2, 2025 18:30
Copilot finished reviewing on behalf of jamesnrokt December 2, 2025 18:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for mParticle Rokt Kit integration by creating a new Cordova plugin package structure. The changes enable partners to use Rokt in conjunction with mParticle by providing a dedicated kit plugin that automatically manages native dependencies. The PR also modernizes the release workflow to support publishing both the core plugin and kit packages.

Key Changes

  • Created a new Rokt Kit plugin package (Kits/Rokt/) with proper plugin.xml and package.json configuration
  • Updated GitHub Actions workflows to automate publishing for both core and kit packages
  • Simplified the example app by removing manual platform-specific hooks in favor of the plugin-based approach
  • Added VERSION file for centralized version management

Reviewed changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
Kits/Rokt/plugin.xml Defines the Rokt Kit Cordova plugin with native dependency specifications for Android and iOS
Kits/Rokt/package.json npm package configuration for the Rokt Kit plugin
Kits/Rokt/README.md Documentation for the Rokt Kit plugin usage
.github/workflows/release-from-main.yml New automated release workflow for publishing packages when VERSION file changes
.github/workflows/draft-release-publish.yml New workflow for creating draft releases with version bumping
.github/workflows/issue-autorespond-and-close.yml Removed auto-close issue workflow
example/config.xml Updated to reference the new Rokt Kit plugin and simplified hook configuration
example/package.json Added Rokt Kit plugin as a dev dependency
example/package-lock.json Updated lock file with new dependencies and version changes
example/README.md Enhanced documentation explaining kit plugin installation
example/platform_overrides/* Removed iOS Podfile and Android build-extras.gradle files
example/hooks/after_platform_add/* Removed manual hook scripts for pod install and gradle configuration
VERSION Added centralized version file containing "2.2.4"
Files not reviewed (1)
  • example/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jamesnrokt jamesnrokt requested a review from a team December 2, 2025 19:14
Copy link
Member

@rmi22186 rmi22186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 main pieces of feedback.

  1. Do we want to have the version of the Rokt kit be the same as the main MP Cordova plugin? That would mean releasing a new version of MP Cordova any time we want to update the iOS/Android kit versions, right? I'd like to avoid that since these are technically independent plugins. It probably matters less on Cordova given usage, but this could be revisted once we align our core SDK/kit versioning strategy.
  2. Non-blocking so that we can just get this out, but I think we need to have a discussion on how we can leverage semantic-release in the Rokt ecosystem as well. Seems like having a file just for VERSION is redundant of having a tag, and perhaps the VERSION file.

@rmi22186
Copy link
Member

rmi22186 commented Dec 2, 2025

Regarding additional notes - is there a reason we need to publish the rokt kit manually first before running this?

discussed live and confirmed that we will publish the rokt kit first due to needing it to be published before OIDC is enabled in the github repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants