refactor: reorganization of modules #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I understand this is a big change @maaslalani let me know if this is ok with you or you had a different structure in mind |
pyrite357
reviewed
Jul 12, 2023
| "github.com/spf13/pflag" | ||
| "gopkg.in/yaml.v3" | ||
| ) | ||
|
|
||
| func importData(path string, structure *utils.Invoice, flags *pflag.FlagSet) error { | ||
| func ImportData(path string, structure *Invoice, flags *pflag.FlagSet) error { |
There was a problem hiding this comment.
is switching away from camelCase necessary?
There was a problem hiding this comment.
Go modules export by case. Uppercase functions get exported, lowercase are private to the module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is a pain testing locally and extending the API due to depending on linking to run the program. (Could be wrong but haven't found a way to test it without building)
The intention is to leave a simple structure that allows extension without much overhead for any maintainer and can introduce some basic tests per module
Changes
cmdmoduleutilsmoduleassetsmodulemain