Added browser storage handling as seperate extension#1025
Merged
macbre merged 6 commits intomacbre:develfrom Dec 9, 2021
EXXETA:add-storage-handling
Merged
Added browser storage handling as seperate extension#1025macbre merged 6 commits intomacbre:develfrom EXXETA:add-storage-handling
macbre merged 6 commits intomacbre:develfrom
EXXETA:add-storage-handling
Conversation
…rage of Browser object
macbre
reviewed
Nov 17, 2021
Owner
|
Thanks for your PR, @kevinkammleiter ! A few small things to clean up before this can be merged:
Thanks once again! |
Contributor
Author
Thanks for the suggested improvements. 👍 I will start soon with implementing the changes and update the pull request. |
Contributor
Author
|
Hi @macbre! I added the changes you suggested. Thanks again for the hints! 👍 |
macbre
reviewed
Dec 7, 2021
macbre
reviewed
Dec 7, 2021
| "session-storage": "bar=foo" | ||
| metrics: | ||
| session-storage: '{"bar":"foo"}' | ||
|
|
Owner
|
@kevinkammleiter - thanks for contributing, merging! |
Owner
|
Actually, @kevinkammleiter - can you apply my above suggestion (regarding wording in |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello guys,☺️
we have a little contribution for you and it would be great, if you could review the changes and hopefully bringing this in a future release
For authentication purposes it could be useful, to have the ability to inject several session-/localStorage values into the page handled by puppeteer.
This extension will use the phantomas parameter sessionStorage and localStorage and inject them into the page storage respectively.