Added support for Redis host and port arguments #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 I need this to run juggernaut in rails test environment, which connects to redis in a different port |
|
+1 this patch works well for connecting to a different host redis is running on |
|
+1 |
4 similar comments
|
+1 |
|
+1 |
|
+1 |
|
+1 |
|
👍 I was seeing exactly this here... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated server.js to accept --redisport and --redishost arguments.
Values are passed to listen(), and normalized to defaults. From here forwarded along through the application.
A minor 'refactorish' change: Events.client is no longer created inline. Instead publish inits channel which inits event with proper redis information.
We're using this in production today. I'm interested in feedback/drawbacks of the implementation. I have another patch that allows the use of Redis.namespace for namespaced redis instances.