Skip to content

feat!: Make RSS <source @url> attribute required following the spec #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat!: Make RSS <source @url> attribute required following the spec #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/feeds/rss/common/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export namespace Rss {

export type Source = {
title: string
url?: string
url: string
}

export type Item<TDate extends DateLike> = {
Expand Down
4 changes: 3 additions & 1 deletion src/feeds/rss/generate/utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,12 +370,14 @@ describe('generateSource', () => {
expect(generateSource(value)).toEqual(expected)
})

it('should generate source with minimal properties', () => {
it('should generate source with all required properties', () => {
const value = {
title: 'Example Source',
url: 'https://example.com/feed.xml',
}
const expected = {
'#text': 'Example Source',
'@url': 'https://example.com/feed.xml',
}

expect(generateSource(value)).toEqual(expected)
Expand Down