Supports metrics of Redis / Valkey cluster. #1388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fetches cluster metris with "CLUSTER INFO" when cluster_enabled.
Valid unit values are "float", "integer", "percentage", "seconds", "milliseconds", "bytes", "bytes/sec", "bits/sec", "iops". https://mackerel.io/ja/docs/entry/advanced/custom-metrics#graph-schema A "count" raises a error while posting graph defs. > ERROR <agent> Failed to create graphdefs: API request failed: Invalid Parameter: obj[2].unit validate.error.unexpected.value.
fujiwara
commented
Dec 16, 2025
| graphdef["offset_delay"] = mp.Graphs{ | ||
| Label: (labelPrefix + " Slave Offset Delay"), | ||
| Unit: "count", | ||
| Unit: "integer", |
Contributor
Author
There was a problem hiding this comment.
This breaks posting graph defs.
ERROR Failed to create graphdefs: API request failed: Invalid Parameter: obj[2].unit validate.error.unexpected.value.
May be by this commit 0738bad (8 years ago...)
yseto
approved these changes
Dec 16, 2025
Contributor
yseto
left a comment
yseto
left a comment
There was a problem hiding this comment.
Thanks for your contribution.
Contributor
|
@fujiwara |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR enables to fetch metrics of a Redis/Valkey cluster node.
Fetches cluster metrics with "CLUSTER INFO" when
cluster_enabled.https://redis.io/docs/latest/commands/cluster-info/
Four graphs will be added if a redis/valkey node enables cluster mode.