Implemented the alert logs API #169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appare45
force-pushed
the
add-alerts-logs-api
branch
from
b4fa36a to
bf240d9
Compare
appare45
changed the title
appare45
force-pushed
the
add-alerts-logs-api
branch
from
bf240d9 to
08edb4a
Compare
roodni
reviewed
Mar 4, 2025
| @@ -381,3 +381,104 @@ func TestGetAlert(t *testing.T) { | |||
| t.Errorf("Wrong data for alert: %v", alert) | |||
| } | |||
| } | |||
|
|
|||
| func TestFindAlertLogs(t *testing.T) { | |||
There was a problem hiding this comment.
[should] Missing test for FindAlertLogsByNextID
There was a problem hiding this comment.
alerts.go
Outdated
Comment on lines
135
to
146
| func (c *Client) FindAlertLogs(alertId string) (*AlertLogsResp, error) { | ||
| path := fmt.Sprintf("/api/v0/alerts/%s/logs", alertId) | ||
| return requestGet[AlertLogsResp](c, path) | ||
| } | ||
|
|
||
| // FindAlertLogsByNextID finds alert logs by next id. | ||
| func (c *Client) FindAlertLogsByNextID(alertId, nextId string) (*AlertLogsResp, error) { | ||
| params := url.Values{} | ||
| params.Set("nextId", nextId) | ||
| path := fmt.Sprintf("/api/v0/alerts/%s/logs", alertId) | ||
| return requestGetWithParams[AlertLogsResp](c, path, params) | ||
| } |
There was a problem hiding this comment.
The parameter limit cannot be set in these functions.
limit cannot be set in FindAlerts either, but I am not confident that it is correct.
There was a problem hiding this comment.
Refactored to use params for request as struct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented alert logs API for the client.
https://mackerel.io/ja/blog/entry/weekly/20250220#:~:text=mackerel.io-,%E3%82%A2%E3%83%A9%E3%83%BC%E3%83%88%E3%81%AE%E3%83%AD%E3%82%B0%E3%82%92%E5%8F%96%E5%BE%97%E3%81%A7%E3%81%8D%E3%82%8BAPI%E3%82%92%E8%BF%BD%E5%8A%A0%E3%81%97%E3%81%BE%E3%81%97%E3%81%9F,-%E3%82%A2%E3%83%A9%E3%83%BC%E3%83%88ID%E3%81%8B%E3%82%89
https://mackerel.io/api-docs/entry/alerts#logs