Skip to content

portconfigure: ensure SDK directory is not empty#288

Open
MarcusCalhoun-Lopez wants to merge 1 commit intomacports:masterfrom
MarcusCalhoun-Lopez:sdk_fix
Open

portconfigure: ensure SDK directory is not empty#288
MarcusCalhoun-Lopez wants to merge 1 commit intomacports:masterfrom
MarcusCalhoun-Lopez:sdk_fix

Conversation

@MarcusCalhoun-Lopez
Copy link
Contributor

On older versions of macOS (e.g. OS X El Capitan), even though "macosxfake" is not a valid SDK,
env DEVELOPER_DIR="/Library/Developer/CommandLineTools" /usr/bin/xcrun --show-sdk-path --sdk macosxfake has zero exit value but outputs an empty string.

On older versions of macOS (e.g. OS X El Capitan), even though
"macosxfake" is not a valid SDK,
`env DEVELOPER_DIR="/Library/Developer/CommandLineTools" /usr/bin/xcrun --show-sdk-path --sdk macosxfake`
has zero exit value but outputs an empty string.
@jmroot
Copy link
Member

jmroot commented Jan 5, 2023

When does this make a difference? Normally on these OS versions with the CLTs installed we would already have returned on line 560 or 567.

@MarcusCalhoun-Lopez
Copy link
Contributor Author

Instead of tracking down when the behavior of xcrun changed or worrying about the possibility of a Portfile changing configure.sdk_version, this seemed safer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants