Skip to content

coverage.yml and main.yml: silence actionlint warnings#341

Open
cooljeanius wants to merge 5 commits intomacports:masterfrom
cooljeanius:actionlint
Open

coverage.yml and main.yml: silence actionlint warnings#341
cooljeanius wants to merge 5 commits intomacports:masterfrom
cooljeanius:actionlint

Conversation

@cooljeanius
Copy link

Without this PR, actionlint prints the following warnings on this repo's GitHub Actions workflows:

$ actionlint
.github/workflows/coverage.yml:33:9: shellcheck reported issue in this script: SC2046:warning:2:8: Quote this to prevent word splitting [shellcheck]
   |
33 |         run: |
   |         ^~~~
.github/workflows/coverage.yml:45:9: shellcheck reported issue in this script: SC2086:info:5:119: Double quote to prevent globbing and word splitting [shellcheck]
   |
45 |         run: |
   |         ^~~~
.github/workflows/coverage.yml:45:9: shellcheck reported issue in this script: SC2086:info:6:84: Double quote to prevent globbing and word splitting [shellcheck]
   |
45 |         run: |
   |         ^~~~
.github/workflows/main.yml:28:9: shellcheck reported issue in this script: SC2006:style:1:7: Use $(...) notation instead of legacy backticks `...` [shellcheck]
   |
28 |         run: |
   |         ^~~~
.github/workflows/main.yml:46:9: shellcheck reported issue in this script: SC2046:warning:4:18: Quote this to prevent word splitting [shellcheck]
   |
46 |         run: |
   |         ^~~~
.github/workflows/main.yml:46:9: shellcheck reported issue in this script: SC2046:warning:6:17: Quote this to prevent word splitting [shellcheck]
   |
46 |         run: |
   |         ^~~~

This PR silences them.

mostly from shellcheck about variable quoting
@cooljeanius
Copy link
Author

Would it make sense for me to handle yamllint warnings in this PR, too, or should I open a separate PR for that?

...instead of silencing them
Tweak style to conform to review comment
@cooljeanius
Copy link
Author

Follow-up: the coverage workflow is now failing on me in other branches in my fork, for example, cooljeanius#4. Could that potentially be related to one of the things that shellcheck is warning about here?

Get rid of old case value left over from previous merge attempt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants