Add portversion property to builds #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mojca
commented
Jul 12, 2021
buildbot/master.cfg
Outdated
| logdir = os.path.join(portbuilder_factory.workdir, 'logs') | ||
|
|
||
| portbuilder_factory.addStep(steps.SetPropertyFromCommand( | ||
| command=['port', 'info', '--version', '--line', util.Interpolate('%(prop:portname)s')], |
Member
Author
There was a problem hiding this comment.
This potentially doesn't use the correct prefix for port. Maybe it should have been something in the spirit of
util.WithProperties(prefix) + '/bin/port'
instead, but I have no clue how to make that work.
Alternatively I could modify mpbb and print the version next to build statistics, but this approach with setting the property sounds much cleaner to me.
We could use something similar to macports/mpbb@11548bc with a standalone mpbb command to extract the version. I know how to do that, but it sounds like a bit of an overkill.
Member
Author
|
@ryandesign: did you have any chance testing this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for macports/macports-webapp#135
The first commit has been tested under buildbot 2.x a while ago, I haven't tested it under 0.8 yet.
The second commit is a pure speculation that tries to use the
portcommand with the correct prefix.See: https://trac.macports.org/ticket/56028