poc(web): compile icons through unplugin-icons and use em to size icons - #6087
Draft
dev-rb wants to merge 1 commit into
Draft
poc(web): compile icons through unplugin-icons and use em to size icons#6087dev-rb wants to merge 1 commit into
unplugin-icons and use em to size icons#6087dev-rb wants to merge 1 commit into
Conversation
Wire Phosphor and custom SVGs as ~icons modules at the default 1.2em scale, and size Button icons from font-size so a class on the icon still wins.
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dev-rb
changed the title
unplugin-icons and use em to size icons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a POC to show moving the icon rendering to be text size based rather than our current absolute rem sizes and also utilizing
unplugin-iconsto centralize icon imports. Looks at thetheme-debugview buttons to get a better look at how it stylesWire Phosphor and custom SVGs as ~icons modules at the default 1.2em scale, and size Button icons from font-size so a class on the icon still wins.