POC: magic chip UI update - #6116
Draft
dev-rb wants to merge 6 commits into
Draft
Conversation
Hold a dedicated loading presentation until the session fold is ready, then project that onto a fixed pill so the channel row does not grow with the answer.
Render the preview chip at a fixed height with hover actions, and keep expand-in-place as a separate opened view so streaming no longer jumps the thread.
Mount fixture chips at /app/component/magic-chip so pill and opened states can be checked without a live session.
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
A channel reply remounted the thread via Show keyed on the message object, which replayed the loading swipe. The pill also joined every text part in the turn instead of the latest utterance.
The playground needs to load on shared preview hosts, not only Vite HMR.
The 40px frame sat tall in the message column; 32px matches a compact chip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.