fix(calendar): name a shared calendar organizer instead of its address - #6228
fix(calendar): name a shared calendar organizer instead of its address#6228gbirman wants to merge 1 commit into
Conversation
…address The Macro profile lookup falls back to the email for an address without a profile, which shadowed the organizer name the source supplied. Search and soup rows for events organized by a shared calendar now read its display name.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe calendar organizer name logic now ignores a resolved Macro name when it matches the organizer email. It then uses the source organizer name or email. New tests cover shared calendar names, Macro profile names, and email fallback behavior. Merge Risk: ⚪ Minimal · up to Calendar rows now retain shared calendar names when profile resolution only returns the raw address, while preserving Macro profile-name precedence and email fallback. No current merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
A calendar row shows its organizer as the Macro profile name when the address resolves to one, otherwise the name the source supplied, otherwise the email. The profile lookup returns the email itself for an address without a profile, so a shared calendar's organizer, a
c_…@group.calendar.google.comaddress whose display name is the calendar's, rendered as the raw address in search and soup rows. The fallback no longer counts as a resolved profile, so those rows readMacro Vacation.Note
Low Risk
Localized display logic for calendar organizer labels with new unit tests; no auth, data, or API changes.
Overview
Calendar list rows were showing shared Google calendar organizers as raw
group.calendar.google.comaddresses becausegetDisplayNameechoes the email when there is no Macro profile, and that value was treated as a successful profile resolution—blocking the calendar source’s display name.organizerNamenow only uses the profile lookup when the resolved string is not the organizer email; otherwise it keeps the prior order: source-supplied name, then email.CalendarEventWhen/ wide rows pick up the fix through the same helper.Adds
calendar.test.tsxcovering shared-calendar naming, Macro profile preference, and email-only fallback.Reviewed by Cursor Bugbot for commit 22a0bb1. Bugbot is set up for automated code reviews on this repo. Configure here.