Skip to content

fix(calendar): name a shared calendar organizer instead of its address - #6228

Open
gbirman wants to merge 1 commit into
mainfrom
gbirman/calendar-organizer-name
Open

fix(calendar): name a shared calendar organizer instead of its address#6228
gbirman wants to merge 1 commit into
mainfrom
gbirman/calendar-organizer-name

Conversation

@gbirman

@gbirman gbirman commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

A calendar row shows its organizer as the Macro profile name when the address resolves to one, otherwise the name the source supplied, otherwise the email. The profile lookup returns the email itself for an address without a profile, so a shared calendar's organizer, a c_…@group.calendar.google.com address whose display name is the calendar's, rendered as the raw address in search and soup rows. The fallback no longer counts as a resolved profile, so those rows read Macro Vacation.


Note

Low Risk
Localized display logic for calendar organizer labels with new unit tests; no auth, data, or API changes.

Overview
Calendar list rows were showing shared Google calendar organizers as raw group.calendar.google.com addresses because getDisplayName echoes the email when there is no Macro profile, and that value was treated as a successful profile resolution—blocking the calendar source’s display name.

organizerName now only uses the profile lookup when the resolved string is not the organizer email; otherwise it keeps the prior order: source-supplied name, then email. CalendarEventWhen / wide rows pick up the fix through the same helper.

Adds calendar.test.tsx covering shared-calendar naming, Macro profile preference, and email-only fallback.

Reviewed by Cursor Bugbot for commit 22a0bb1. Bugbot is set up for automated code reviews on this repo. Configure here.

…address

The Macro profile lookup falls back to the email for an address without a profile, which shadowed the organizer name the source supplied. Search and soup rows for events organized by a shared calendar now read its display name.
@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: f5e46042-010b-410a-a851-b1e8aa62eb5c

📥 Commits

Reviewing files that changed from the base of the PR and between f598574 and 22a0bb1.

📒 Files selected for processing (2)
  • apps/web/src/features/entity/composed/list-entity/calendar.test.tsx
  • apps/web/src/features/entity/composed/list-entity/calendar.tsx

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Bug Fixes

    • Calendar events now display the supplied name for shared calendars instead of incorrectly showing their email address.
    • Organizer names from Macro profiles are prioritized when available.
    • Email addresses are used as a fallback only when no profile or organizer name is provided.
  • Tests

    • Added coverage for shared calendar names, profile name precedence, and email fallback behavior.

Walkthrough

The calendar organizer name logic now ignores a resolved Macro name when it matches the organizer email. It then uses the source organizer name or email. New tests cover shared calendar names, Macro profile names, and email fallback behavior.

Merge Risk: ⚪ Minimal · up to 22a0b

Calendar rows now retain shared calendar names when profile resolution only returns the raw address, while preserving Macro profile-name precedence and email fallback. No current merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title uses the conventional commit format with the fix: prefix, describes the shared calendar organizer naming change, and is 70 characters long, under the 72-character limit.
Description check ✅ Passed The description clearly explains the organizer name resolution change, the shared-calendar issue, the fallback order, and the added tests.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

@gbirman gbirman changed the title fix(calendar): show a shared calendar organizer by its name, not its address fix(calendar): name a shared calendar organizer instead of its address Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant