Enable pre-commit, linters and formatters #448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbobrenko
force-pushed
the
feature/SN1-297-enable-linter
branch
from
01a445d to
f106fb9
Compare
bkb2135
approved these changes
Nov 5, 2024
dbobrenko
changed the title
dbobrenko
force-pushed
the
feature/SN1-297-enable-linter
branch
from
1d2b6dd to
f1d25ed
Compare
dbobrenko
force-pushed
the
feature/SN1-297-enable-linter
branch
from
c9d6824 to
362245a
Compare
dbobrenko
changed the base branch from
staging
to
SN1-260-rework-validator-to-use-epistula
dbobrenko
changed the title
bkb2135
merged commit 60a043e
into
SN1-260-rework-validator-to-use-epistula
2 checks passed
richwardle
reviewed
Nov 22, 2024
| - name: Test with pytest | ||
| run: | | ||
| # run tests in tests/ dir and only fail if there are failures or errors |
Contributor
There was a problem hiding this comment.
Moving the cache step before installing dependencies might help pip restore with the cached packages, avoiding redownloading dependencies in following workflow runs. Test this thought I'm not 100%.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
pull-requestwith Github Actions;CONTRIBUTING.md.Overview
Each
git commitwill run pre-commit hook locally, and fix all format/style issues.If commit fails, make sure to add the modified files.
To run pre-commit manually and automatically fix files:
poetry run pre-commit run --all-filesIssues