Skip to content

Revisit logprobs checks #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 24, 2025
Merged

Revisit logprobs checks #688

merged 4 commits into from
Apr 24, 2025

Conversation

dbobrenko
Copy link
Collaborator

@dbobrenko dbobrenko commented Apr 24, 2025 •
edited
Loading

Changes

  • Fix sampling params.
  • Fix logprobs: check for token, change thresholds.
  • Add logprobs tests.

@dbobrenko dbobrenko self-assigned this Apr 24, 2025
bkb2135
bkb2135 approved these changes Apr 24, 2025
View reviewed changes
Copy link
Collaborator

@bkb2135 bkb2135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great to me!

@dbobrenko dbobrenko merged commit f2b3d3c into staging Apr 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkb2135 bkb2135 bkb2135 approved these changes

Assignees

@dbobrenko dbobrenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbobrenko @bkb2135