fix: spring boot applications store database connect... in...#974
Open
orbisai0security wants to merge 1 commit into
Open
Conversation
Automated security fix generated by OrbisAI Security
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
mall-admin/src/main/resources/application.yml.Vulnerability
V-002mall-admin/src/main/resources/application.yml:1Description: Spring Boot applications store database connection strings, passwords, Redis credentials, JWT signing secrets, and third-party API keys in application.yml or application.properties files. The security assessment found no evidence of secrets externalization through Spring Cloud Config, HashiCorp Vault, or environment variable references (${ENV_VAR} syntax) in the mall-admin and mall-security modules. If credentials are hardcoded in these configuration files and committed to version control, any person with repository read access — including developers, contractors, or an attacker who obtains repository access — can extract credentials and directly connect to backend databases, bypassing all Spring Security controls. JWT secret exposure additionally allows forging of arbitrary authentication tokens.
Changes
mall-admin/src/main/resources/application.ymlmall-admin/src/main/resources/application-prod.ymlVerification