Fix: Update Email Validation Regex for Improved Accuracy#62
Merged
0xHexE merged 1 commit intomadari-media:mainfrom Mar 3, 2025
Merged
Fix: Update Email Validation Regex for Improved Accuracy#620xHexE merged 1 commit intomadari-media:mainfrom
0xHexE merged 1 commit intomadari-media:mainfrom
Conversation
…ort more valid email formats
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the email validation regex in the authentication pages to improve accuracy and support a broader range of valid email formats. The previous regex was restrictive and did not allow for some valid email addresses. The updated regex is more permissive and adheres to standard email formatting rules.
Changes:
Updated Regex:
r'^[\w-.]+@([\w-]+\.)+[\w-]{2,4}$'r'^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\.[a-zA-Z]{2,}$'Files Modified:
lib/features/auth/pages/forget_password_page.dartlib/features/auth/pages/signin_page.dartlib/features/auth/pages/signup_page.dartBenefits:
Testing:
Reviewers:
Checklist:
Thank you for your review and approval!