fix: better configs#24
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enables type-checking of test files so that @ts-expect-error and satisfies assertions in the test suite are actually validated, and ensures CI release flows run the typecheck step.
Changes:
- Include
testsdirectory intsconfig.jsonsotsc --noEmitcovers test files. - Enable Vitest's built-in
typecheckrunner pointed attsconfig.json. - Add
bun run typechecksteps before tests in both release and canary jobs ofrelease.yml.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tsconfig.json |
Adds tests to include so test type assertions are checked. |
vitest.config.ts |
Enables Vitest typecheck integration using project tsconfig. |
.github/workflows/release.yml |
Adds typecheck step prior to tests in release and canary jobs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Better project configs.
Why?
No type checking tests were running.
Checklist