Skip to content

Conversation

@cmrschwarz
Copy link
Contributor

implements #62

type Abi = <JsType as IntoWasmAbi>::Abi;
#[inline]
fn into_abi(self) -> Self::Abi {
(&self).into_abi()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, you're making &Borrow the "real" implementation and using that to handle the Borrow case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jup! This is of course just a testcase, Borrow is defined here. I simply ran MACROTEST=overwrite cargo test to update these.

@siefkenj
Copy link
Collaborator

This looks great! Would you be able to add an end-to-end test?

@cmrschwarz
Copy link
Contributor Author

This looks great! Would you be able to add an end-to-end test?

done :).

@cmrschwarz
Copy link
Contributor Author

huh. failure seems unrelated?

@cmrschwarz
Copy link
Contributor Author

cmrschwarz commented May 16, 2025

Seems related to this issue: jetli/wasm-pack-action#23
we probably got unlucky with the runner on the second ci but not the first.
Edit: yep, first ci got wasm-pack 13.1, second one got 9.1. what a scam 😅 .

I guess we could just rerun and hope to get a runner thats up to date.

@siefkenj siefkenj merged commit 910187f into madonoharu:main May 16, 2025
5 of 6 checks passed
@siefkenj
Copy link
Collaborator

Thanks for this!

@cmrschwarz
Copy link
Contributor Author

Thank you for maintaining this awesome library <3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants