remove unneeded charset assignment #53
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I have:
I have a column defined as
varchar(255). The default charset of the database is UTF-8.What I'm trying to do:
Saving the string
i'm a unicode string 😁should properly persist it to the database.What happens:
The emoji is replaced.
Why does it happen?
FIBPlus already properly encodes the string. What I think happens is that by setting the
sqlsubtypethe string gets transliterated on the server to the UnicodeFSS Charset (which per https://firebirdsql.org/refdocs/langrefupd25-charsets.html has some problems).By removing the
sqlsubtypeassignment, I'm able to properly save and retrieve the emoji.