improving chat behaviour within a tab

[madox2]

No description provided.

[Konfekt]

Maybe there's a misunderstanding. The idea is that of a toggle inside one fixed tab, the same >>> AI chat 8 opening on :AIChat. With this PR, a new buffer >>> AI chat 9 ... is opened on every :AIChat after closing the window.

[madox2]

It should work only if scratch_buffer_keep_open is enabled. Also inside a new tab it needs to spawn new instance of chat manually, e.g. by :AIC /right and then any consequent :AIC should use that spawned instance in the tab even if window is closed.

[Konfekt]

I had this setting set

let g:vim_ai_chat = {
\  "ui": {
\    "scratch_buffer_keep_open": 1,
\  },
\ }

to the described effect. I'm using :AIChat, :close and :AIChat will open a new buffer with increased number label. In the now closed PR, the closed buffer would resurface again, same number label

[Konfekt]

Would you mind comparing it to former #203 ?

[madox2]

Hi, I tried to reproduce exactly as you described but it works as expected. Even from the fact how scratch_buffer_keep_open = 1 works it will never spawn a new istance of the chat, unless you use ui.force_new_chat, but you didn't mention that. Also attaching screencast.

[Konfekt]

The idea of #204 was that on the second :AIChat the entered text aaa in the buffer would resurface

[madox2]

I can't reproduce, did everything as you in the gif video and it works as expected. By any chance don't you use force_new_chat in a default configuration/role or have some custom function? If not, can you try it in a clean vim without plugins and with default vim-ai configuration?

[Konfekt]

In the tab-local-chat branch with

let &rtp = '~/.vim/plugged/vim-ai' . ',' . &rtp
filetype plugin indent on
syntax on
let g:vim_ai_chat = {
      \  "ui": {
      \    "scratch_buffer_keep_open": 1,
      \  },
      \ }

With

let &rtp = '~/.vim/plugged/vim-ai' . ',' . &rtp
filetype plugin indent on
syntax on

In this branch scratch_buffer_keep_open will throw shown errors, without it, the buffer is reset.
Instead, the idea of #203 is that the same buffer where aaa was entered will resurface.

[madox2]

Okay, that's a good catch, I fixed the error. You can try now

[Konfekt]

Same as before,

the buffer is reset.
Instead, the idea of #203 is that the same buffer where aaa was entered will resurface.

[Konfekt]

[madox2]

You obviously don't have clean vim-ai configuration, because the default chat is not supposed to open in the right panel. So I guess there is some misconfiguration on your side. Well clean config but scratch_buffer_keep_open enabled

[Konfekt]

In #203 it also works with dirty configuration; why shouldn't it? What's the win here?

[Konfekt]

For the record, "open_chat_command": "preset_right", was enabled

[madox2]

I was trying to find out why it is not working for you when it obviously should. If you can't reproduce it on the clean configuration, then it points to your "dirty configuration", otherwise is the problem somewhere else in your environment. Anyway, I tested it on different environments with different kind of setup, should be working, I not going to invest more time into this.