Mutation testing#113
Conversation
| .env.*.local | ||
| .env.local | ||
| .env.local.php | ||
| .env.test |
There was a problem hiding this comment.
Some registrar tests use a "dry run" flag. If mutation testing is performed, modifying this flag should be prevented, otherwise unintentional domain registrations could occur.
There was a problem hiding this comment.
You can't run any tests if you don't have an appropriate .env for tests. J think your two main options are:
- separate .env.test for mutation testing without any tokens
- exclude provider classes with the infection config
| build: | ||
| context: . | ||
| target: frankenphp_test | ||
| # command: php infection.php |
There was a problem hiding this comment.
No need for a database for the tests?
It seems to me that some tests do require one.
| rm -rf node_modules; \ | ||
| sync | ||
|
|
||
| #CMD [ "php", "infection.phar" ] |
There was a problem hiding this comment.
This file should be better configured to avoid testing certain patterns.
For example, excluding log creation calls, method visibility, etc.
Also, we could remove files without logic (namespace App\Entity for example).
| "source": { | ||
| "directories": [ | ||
| "src", | ||
| "tests" |
There was a problem hiding this comment.
Is this line required?
You shouldn't modify the test instructions themselves, but rather the code covered by the tests.
2 participants
Describe your changes
Type of change
Please delete options that are not relevant.
Checklist before requesting a review