hd-notification-manager: support boolean values#3
Open
MerlijnWajer wants to merge 1 commit into
Open
Conversation
hd_notification_manager_notify already supported this as an argument for "persistent", but the code would error later on if a boolean was actually set.
Member
Author
|
I just realised that libhildondesktop also has code that does this, and it only accepts uchar. I'll see if I can make conversations generate uchar instead of boolean, but it's still worth considering this PR I suppose, but maybe we should do a bit more digging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hd_notification_manager_notify already supported this as an argument for "persistent", but the code would error later on if a boolean was actually set.