Skip to content

Conversation

@Chris53897
Copy link
Contributor

as nigthly now addresses PHP 8.6, this will add tests for PHP 8.5

@Chris53897
Copy link
Contributor Author

Failing tests on lower PHP versions. Should be fixed in a sperate PR.

@maennchen
Copy link
Owner

The tests are fixed (#390 & #391).

The version bump is currently incomplete. It also needs to be switched in the windows / mac job and in the .tool-versions.

@maennchen
Copy link
Owner

It looks like we'll have to wait for Psalm support for PHP 8.5. Right now the dependencies can't be resolved.

@Chris53897
Copy link
Contributor Author

I added a line to remove psalm for this run, as there is a sperate run on PHP 8.3 with psalm.
But tests are slow. PHP 8.5 ond windows still running. Maybe because of code-coverage with xdebug instead of pcov?

@coveralls
Copy link

coveralls commented Nov 26, 2025

Pull Request Test Coverage Report for Build 19706812761

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on patch-1 at 96.907%

Totals Coverage Status
Change from base Build 19706311221: 96.9%
Covered Lines: 564
Relevant Lines: 582

💛 - Coveralls

@Chris53897
Copy link
Contributor Author

@maennchen
Copy link
Owner

The tests run some very big files. That's unfortunately just slow and there's not much we can do about that. (To test Zip64 properly we need files > 4Gb) That's also why some tests have a slow tag to exclude them for local development.

Running Psalm on 5.3 and not latest was actually an oversight. I switched to use the .tool-versions in #392

Until Psalm has 8.5 compatibility, I'll keep this PR open. I don't want stuff like the composer remove in the actions and I don't see a problem waiting a few more days until our dependencies have caught up.

@Chris53897
Copy link
Contributor Author

ok, lets wait for psalm 6

@Chris53897
Copy link
Contributor Author

@maennchen Ready for review

@maennchen maennchen merged commit 682f109 into maennchen:main Dec 10, 2025
13 checks passed
@Chris53897 Chris53897 deleted the patch-1 branch December 10, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants