-
Notifications
You must be signed in to change notification settings - Fork 218
Initial build of AD DS tests. #1366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
soulemike
wants to merge
11
commits into
maester365:main
Choose a base branch
from
soulemike:ActiveDirectory
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,079
−10
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7c9ab4c
Initial build of AD DS tests.
soulemike 7e58834
Fixing pssingular
soulemike bd0ea97
Fixes
soulemike aa84940
Fixes
soulemike 6fd9f89
Verbose and descriptions
soulemike 5dfe77f
Adding two new checks within the SPN test
soulemike 6d20540
Fix variable reference
soulemike c8a56ee
Init of Forest checks
soulemike 3ce081b
AD Domain tests
soulemike 2566ac5
Cleanup
soulemike aa7374e
Missing file
soulemike File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| <# | ||
| .SYNOPSIS | ||
| Resets the local cache of AD lookups. Use this if you need to force a refresh of the cache in the current session. | ||
|
|
||
| .DESCRIPTION | ||
| By default all AD queries are cached and re-used for the duration of the session. | ||
|
|
||
| Use this function to clear the cache and force a refresh of the data. | ||
|
|
||
| .EXAMPLE | ||
| Clear-MtAdCache | ||
|
|
||
| This example clears the cache of all AD queries. | ||
|
|
||
| .LINK | ||
| https://maester.dev/docs/commands/Clear-MtAdCache | ||
| #> | ||
| function Clear-MtAdCache { | ||
| [Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSUseDeclaredVarsMoreThanAssignments', '', Justification='Setting module level variable')] | ||
| [CmdletBinding()] | ||
| param() | ||
|
|
||
| Write-Verbose -Message "Clearing the results cached from DNS lookups in this session" | ||
|
|
||
| $__MtSession.AdCache = @{} | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'ActiveDirectory' module is not needed in this array. An inline explanatory comment would be helpful: it is checking modules that rely on the MSAL to determine which one should be connected to first, which ensures that the newest (and backwards compatible) version of Microsoft.Identity.Client.dll is loaded to avoid version conflicts between the MS modules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the switch case is dependent on the array returned, does that work as intended?