-
-
Notifications
You must be signed in to change notification settings - Fork 18
feat(account): login with username or email #1869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
195 files changed look odd, should this PR target beta?
|
Yes this will target beta as we have account restyle changes there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR needs a rebase
|
@huzaifaedhi22 what's the status on this? |
* feat(tailwind): add accent colors * feat(button-colored): update secondary style * feat(form-account-sign-in): update registration button * feat(tailwind): add accent fancy * feat(AppLink): update accent color * feat: update ButtonColored component to accept more styles * feat(form): update form design to match new one * chore(i18n): update placeholder text to "Create an account" * feat(footer): create footer component * feat(layout): add footer component to default layout * fix(account): convert route paths to route names in footer component * chore(tests): update visual regression snapshots * chore(tests): add visual regression snapshots * chore(tests): add visual regression test * feat(account): add modals for privacy policy and general terms acceptance * feat(button): add confirm button component * chore(tailwind): add colors to tailwind config * feat(account-register): add privacy policy and general terms modal to signup flow * fix: linting errors * fix(modal): resolve transition issue between modals * feat(account):add uuid field to accountRegistration mutation response * feat(account): add acceptLegalTermAcceptance mutation * feat(account): include legal acceptance mutation in registration flow * chore(gql): update generated gql files * feat(account): add terms id to registration flow * feat(generalTerms): create and use general terms query * Merge branch 'master' into feat/account/restyle * fix(lint): typos in graph ql files * fix(typo) : remove typo * refactor(query): use nodes instead of edges * chore(shad-cn): add shad cn dialogue and shadbutton * chore(colors): add colors from new design * feat(account): implement updated design for account signup and login * refactor(empty-lines):remove * chore(shad-cn): shadcn components index and deps * feat(modals): use shadcn for modals * chore(text): update text * feat(forms): use updated design for forms * feat(styling): update modals for dark mode * feat(validator): add validator to allow both username and email to sign in * chore(colors): add colors * fix(deps): sync lockfile * fix(shadcn): use updated import * fix(shad-button): export as ShadButton to avoid conflict * fix(css): merge app.css and maevsi.css * chore(deps): deduplicate dependencies * fix(turnstile): set token without store * chore(tests) : update tests * fix(styles): pass correct color variable * feat(modals): add back button to modals * fix(termId): add legal term id to account registration mutation * feat(pending-verify): add pending verification email page * chore(gql): update gql files * refactor(verify): create verify directory instead * chore(tests): update tests * chore(tests): add new screenshots * chore(tests): update tests * chore(test): update snapshots * chore(deps): mark compatibility with sqitch v7 * chore: fix back icon * chore: revert readdition of style utility * chore: restyle forms * feat(components): upgrade dialog component * chore(graphql): update schema * refactor(graphql): extract legal term fragment * chore(graphql): reduce returned values for legal term acceptance * fix(account): revert sign in form input to email * refactor(utils): sort validation functions * refactor(components): replace legacy footer * refactor(components): extract footer button * feat(form): align sign in and registration * feat(session): add welcome screen * feat(components): add button size * feat(components): add top bar * feat(form): remove placeholders * chore: work in layout updates * chore(deps): upgrade shadcn-nuxt styles * refactor(legal): extract content component * feat(legal): update report form link * refactor(app): reorder components * fix(app): correct backdrop height * chore(app): remove nuxt layout comment * fix(components): correct icon labels * chore: rework models to stepper * fix(components): correct button variant * fix(components): use `span` for typography * feat(pages): extract legal term page * chore(sqitch): update to v7.0.0-beta.10 * chore: clean up --------- Co-authored-by: huzaifaedhi2 <[email protected]>
a921031 to
d729ff5
Compare
bdac338 to
dd9e044
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure the PRs' diffs look as they should when requesting review
tests/e2e/specs/server/sitemap.spec.ts-snapshots/sitemap-content-de-Mobile-Chrome-linux.xml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments from last review above.
This PR
📝 Checklist