Conversation
maff
force-pushed
the
feature/remove-generic-version-strategy
branch
from
bf0b31a to
d6e3fc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the file structure and import statements to improve code organization and maintainability. The main changes involve moving and renaming files related to version resolution and strategies.
File and Import Reorganization:
index.ts: Updated import paths forresolveVersionandresolveStrategiesto reflect their new locations.src/output/__fixtures__/versionResults.ts,src/output/env.ts,src/output/index.ts,src/output/json.ts,src/output/yaml.ts: Updated import paths forVersionResultto reflect its new location inversion/versionResolver. [1] [2] [3] [4] [5]File Renaming and Refactoring:
src/version/index.ts: Removed the file and moved its contents toversionStrategy.ts.src/version/versionResolver.ts: Renamed fromsrc/versionResolver.tsand updated import paths accordingly.src/version/versionStrategy.ts: Renamed fromsrc/version/genericVersionStrategy.ts, refactored theGenericVersionStrategyclass toVersionStrategy, and moved theresolveStrategiesfunction to this file. [1] [2]