feat: add support for flattened sessions #154
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
=======================================
+ Coverage 39.7% 42.5% +2.7%
=======================================
Files 25 27 +2
Lines 2325 2468 +143
=======================================
+ Hits 924 1048 +124
- Misses 1362 1372 +10
- Partials 39 48 +9 🚀 New features to boost your workflow:
|
mafredri
force-pushed
the
mafredri/flattened-protocol
branch
11 times, most recently
from
a1611ef to
385af26
Compare
Chrome is deprecating non-flattened sessions (crbug.com/991325) where commands are wrapped via Target.SendMessageToTarget. Flattened mode includes the sessionId directly in the JSON-RPC message instead. Add rpcc.NewSession for creating session-scoped connections that share the parent's websocket I/O. WithSessionClose allows registering a cleanup callback for detachment. session.Manager now uses flattened mode by default, requiring Chrome 77+. WithNoFlatten opts into legacy mode for older versions. Closes #109
mafredri
force-pushed
the
mafredri/flattened-protocol
branch
from
385af26 to
2468c63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome is deprecating non-flattened sessions (crbug.com/991325) where
commands are wrapped via Target.SendMessageToTarget. Flattened mode
includes the sessionId directly in the JSON-RPC message instead.
Add rpcc.NewSession for creating session-scoped connections that share
the parent's websocket I/O. WithSessionClose allows registering a
cleanup callback for detachment.
session.Manager now uses flattened mode by default, requiring Chrome 77+.
WithNoFlatten opts into legacy mode for older versions.
Closes #109