Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more version numbers in @deprecated tag #439

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Allow more version numbers in @deprecated tag
fredden committed Dec 8, 2023
commit 8dcb90484943f068d3d3633f3c3aa49d6bdc2ebf
2 changes: 1 addition & 1 deletion Magento2/Helpers/Commenting/PHPDocFormattingValidator.php
Original file line number Diff line number Diff line change
@@ -124,7 +124,7 @@ public function hasDeprecatedWellFormatted($commentStartPtr, $tokens)
$seePtr = $this->getTagPosition('@see', $commentStartPtr, $tokens);
if ($seePtr === -1) {
if (preg_match(
"/This [a-zA-Z]* will be removed in version \d.\d.\d without replacement/",
"/This [a-zA-Z]+ will be removed in version \d+\.\d+\.\d+ without replacement/",
$tokens[$deprecatedPtr + 2]['content']
)) {
return true;